On 2016년 11월 24일 19:52, Joe Perches wrote: > On Thu, 2016-11-24 at 19:46 +0900, Chanwoo Choi wrote: >> On 2016년 11월 24일 19:20, Joe Perches wrote: >>> On Thu, 2016-11-24 at 14:01 +0900, Chanwoo Choi wrote: >>>> This patch just fixes the checkpatch warnings. >>> >>> unrelated trivia: >>> >>>> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c > [] >>>> @@ -576,11 +575,13 @@ struct devfreq *devfreq_add_device(struct device >>>> *dev, >>>> goto err_out; >>>> } >>>> >>>> - devfreq->trans_table = devm_kzalloc(&devfreq->dev, sizeof(unsigned >>>> int) * >>>> + devfreq->trans_table = devm_kzalloc(&devfreq->dev, >>>> + sizeof(unsigned int) * >>>> devfreq->profile->max_state * >>>> devfreq->profile->max_state, >>>> GFP_KERNEL); >>>> - devfreq->time_in_state = devm_kzalloc(&devfreq->dev, sizeof(unsigned >>>> long) * >>>> + devfreq->time_in_state = devm_kzalloc(&devfreq->dev, >>>> + sizeof(unsigned long) * >>>> devfreq->profile->max_state, >>>> GFP_KERNEL); >>> >>> Maybe these should be devm_kcalloc calls >> >> Why should devfreq use the devm_kcalloc? > > Because these are allocating zeroed arrays of a specific size.
kzalloc is already set to zero. [1]https://www.kernel.org/doc/htmldocs/kernel-api/API-kzalloc.html
