> I like this. The nice thing is that since "name" is a string, we're not > locked into an enum -- drivers report what they have using 802.3 > vocabulary, and we document the recommended names (pcs, pma, pmd, mii) > with references? That way it's unambiguous, but not too constrained.
It is both good and bad. I expect some vendors will just ignore the text and use what their data sheet says, because they don't know better. An enum forces more consistency. https://gist.github.com/mjball/9cd028ac793ae8b351df1379f1e721f9 enum gets you around level 9. string around level 3. Andrew

