On 11/03/2026 16:30, Andrew Lunn wrote: >> I like this. The nice thing is that since "name" is a string, we're not >> locked into an enum -- drivers report what they have using 802.3 >> vocabulary, and we document the recommended names (pcs, pma, pmd, mii) >> with references? That way it's unambiguous, but not too constrained. > > It is both good and bad. I expect some vendors will just ignore the > text and use what their data sheet says, because they don't know > better. An enum forces more consistency. > > https://gist.github.com/mjball/9cd028ac793ae8b351df1379f1e721f9 > > enum gets you around level 9. string around level 3. > > Andrew Oh didn't know that manifesto. Givent the current discussions I'm indeed starting to think an enum value will be enough to cover a good portion of the usecases, so I'm OK with it :) Maxime
- [PATCH net-next 00/11] ethtool: Generic loopback support Björn Töpel
- [PATCH net-next 10/11] netdevsim: Add module EEPROM... Björn Töpel
- Re: [net-next,10/11] netdevsim: Add module EEPR... Jakub Kicinski
- [PATCH net-next 02/11] ethtool: Add loopback netlin... Björn Töpel
- Re: [PATCH net-next 02/11] ethtool: Add loopbac... Maxime Chevallier
- Re: [PATCH net-next 02/11] ethtool: Add loo... Björn Töpel
- Re: [PATCH net-next 02/11] ethtool: Add... Andrew Lunn
- Re: [PATCH net-next 02/11] ethtool... Maxime Chevallier
- Re: [PATCH net-next 02/11] eth... Andrew Lunn
- Re: [PATCH net-next 02/11] ethtool... Jakub Kicinski
- Re: [PATCH net-next 02/11] eth... Andrew Lunn
- Re: [PATCH net-next 02/11]... Jakub Kicinski
- Re: [PATCH net-next 02/11] ethtool: Add loo... Oleksij Rempel
- Re: [PATCH net-next 02/11] ethtool: Add... Jakub Kicinski
- Re: [PATCH net-next 02/11] ethtool: Add loo... Andrew Lunn
- Re: [PATCH net-next 02/11] ethtool: Add... Maxime Chevallier
- Re: [PATCH net-next 02/11] ethtool... Andrew Lunn
- Re: [PATCH net-next 02/11] eth... Jakub Kicinski

