On Fri, Mar 27, 2026 at 09:11:43PM +0100, Barnabás Czémán wrote: > Remove modem related bindings from MSM8953 rpmpd because MSM8953 MSS > is using mss-supply as a regulator usually it is pm8953_s1. > Split SDM632 bindings from MSM8953 because SDM632 is using mss-supply > as a pm domain. > > Signed-off-by: Barnabás Czémán <[email protected]> > --- > .../devicetree/bindings/power/qcom,rpmpd.yaml | 1 + > include/dt-bindings/power/qcom-rpmpd.h | 20 > +++++++++++++------- > 2 files changed, 14 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml > b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml > index 8174ceeab572..659936d6a46e 100644 > --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml > +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml > @@ -48,6 +48,7 @@ properties: > - qcom,sc7280-rpmhpd > - qcom,sc8180x-rpmhpd > - qcom,sc8280xp-rpmhpd > + - qcom,sdm632-rpmpd > - qcom,sdm660-rpmpd > - qcom,sdm670-rpmhpd > - qcom,sdm845-rpmhpd > diff --git a/include/dt-bindings/power/qcom-rpmpd.h > b/include/dt-bindings/power/qcom-rpmpd.h > index 4371ac941f29..2d82434b993c 100644 > --- a/include/dt-bindings/power/qcom-rpmpd.h > +++ b/include/dt-bindings/power/qcom-rpmpd.h > @@ -84,13 +84,11 @@ > #define QM215_VDDMX_AO MSM8917_VDDMX_AO > > /* MSM8953 Power Domain Indexes */ > -#define MSM8953_VDDMD 0
ABI break / impact and due to two changes combined I don't really understand why. Why MSS using mss-supply makes this ABI invalid/wrong? > -#define MSM8953_VDDMD_AO 1 > -#define MSM8953_VDDCX 2 > -#define MSM8953_VDDCX_AO 3 > -#define MSM8953_VDDCX_VFL 4 > -#define MSM8953_VDDMX 5 > -#define MSM8953_VDDMX_AO 6 > +#define MSM8953_VDDCX RPMPD_VDDCX > +#define MSM8953_VDDCX_AO RPMPD_VDDCX_AO > +#define MSM8953_VDDCX_VFL RPMPD_VDDCX_VFL > +#define MSM8953_VDDMX RPMPD_VDDMX > +#define MSM8953_VDDMX_AO RPMPD_VDDMX_AO I don't see how this is related to new compatible and SDM632. > > /* MSM8974 Power Domain Indexes */ > #define MSM8974_VDDCX 0 > @@ -156,6 +154,14 @@ > #define QCS404_LPIMX 5 > #define QCS404_LPIMX_VFL 6 Best regards, Krzysztof
