On 3/28/26 9:22 AM, Barnabás Czémán wrote: > On 2026-03-27 21:26, Dmitry Baryshkov wrote: >> On Fri, Mar 27, 2026 at 09:11:43PM +0100, Barnabás Czémán wrote: >>> Remove modem related bindings from MSM8953 rpmpd because MSM8953 MSS >>> is using mss-supply as a regulator usually it is pm8953_s1. >>> Split SDM632 bindings from MSM8953 because SDM632 is using mss-supply >>> as a pm domain. >>> >>> Signed-off-by: Barnabás Czémán <[email protected]> >>> --- >>> .../devicetree/bindings/power/qcom,rpmpd.yaml | 1 + >>> include/dt-bindings/power/qcom-rpmpd.h | 20 >>> +++++++++++++------- >>> 2 files changed, 14 insertions(+), 7 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml >>> b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml >>> index 8174ceeab572..659936d6a46e 100644 >>> --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml >>> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml >>> @@ -48,6 +48,7 @@ properties: >>> - qcom,sc7280-rpmhpd >>> - qcom,sc8180x-rpmhpd >>> - qcom,sc8280xp-rpmhpd >>> + - qcom,sdm632-rpmpd >>> - qcom,sdm660-rpmpd >>> - qcom,sdm670-rpmhpd >>> - qcom,sdm845-rpmhpd >>> diff --git a/include/dt-bindings/power/qcom-rpmpd.h >>> b/include/dt-bindings/power/qcom-rpmpd.h >>> index 4371ac941f29..2d82434b993c 100644 >>> --- a/include/dt-bindings/power/qcom-rpmpd.h >>> +++ b/include/dt-bindings/power/qcom-rpmpd.h >>> @@ -84,13 +84,11 @@ >>> #define QM215_VDDMX_AO MSM8917_VDDMX_AO >>> >>> /* MSM8953 Power Domain Indexes */ >>> -#define MSM8953_VDDMD 0 >>> -#define MSM8953_VDDMD_AO 1 >>> -#define MSM8953_VDDCX 2 >>> -#define MSM8953_VDDCX_AO 3 >>> -#define MSM8953_VDDCX_VFL 4 >>> -#define MSM8953_VDDMX 5 >>> -#define MSM8953_VDDMX_AO 6 >>> +#define MSM8953_VDDCX RPMPD_VDDCX >>> +#define MSM8953_VDDCX_AO RPMPD_VDDCX_AO >>> +#define MSM8953_VDDCX_VFL RPMPD_VDDCX_VFL >>> +#define MSM8953_VDDMX RPMPD_VDDMX >>> +#define MSM8953_VDDMX_AO RPMPD_VDDMX_AO >> >> Well, no. This is an ABI break. It will make previous DT to stop from >> working. You can drop unused indices, but you can not change the values >> used by the existing domains. > Do these indices never can be changed?
Yes, values in include/dt-bindings are supposed to never change Here you're e.g. changing the "msm8953 domain 0" from translating into VDDMD to translating into VDDCX (because RPMPD_VDDCX is defined as 0) Some other older platforms were converted to use these macros, because the indices happened to match Konrad
