> Mauro, > > I have submitted the doc patch for review. But no comments so far.
I'll review it tomorrow. I did a quick scan earlier and saw several things that needs improvement, but I simply did not have time to write it all down in a review. Regards, Hans > > Murali Karicheri > Software Design Engineer > Texas Instruments Inc. > Germantown, MD 20874 > phone: 301-407-9583 > email: m-kariche...@ti.com > >>-----Original Message----- >>From: Mauro Carvalho Chehab [mailto:mche...@infradead.org] >>Sent: Tuesday, November 24, 2009 11:42 AM >>To: Hans Verkuil >>Cc: v4l-dvb; Karicheri, Muralidharan >>Subject: Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-timings >> >>Hans Verkuil wrote: >>> Hi Mauro, >>> >>> Please pull from http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-timings >>> for >>> the following: >>> >>> - v4l: Adding Digital Video Timings APIs >>> >>> This adds an important missing piece to the V4L2 API: the ability to >>> receive and transmit HDTV video. >>> >>> The documentation needs another review cycle, mostly for grammar and >>> style, but that should prevent this patch from going in. >> >>I had some bad experiences of not merging both specs and patches at the >>same >>time... DVB S2 API were added one year ago, and the promises were that >> the >>doc patches would be sent 1-2 weeks after the merge... we're still >> waiting >>for it... >> >>So, please submit both specs and code changes at the same pull request. >> >>As a bonus, reviewing both docs and patches at the same time are easier >>than doing it in separate. >> >>> >>> Many thanks to Murali and everyone else who has been involved in the >>> discussions and reviews for this new API. >>> >>> Thanks, >>> >>> Hans >>> >>> diffstat: >>> drivers/media/video/v4l2-compat-ioctl32.c | 6 + >>> drivers/media/video/v4l2-ioctl.c | 147 >>> ++++++++++++++++++++++++++++++ >>> include/linux/videodev2.h | 116 >>> +++++++++++++++++++++++ >>> include/media/v4l2-ioctl.h | 15 +++ >>> include/media/v4l2-subdev.h | 21 ++++ >>> 5 files changed, 303 insertions(+), 2 deletions(-) >>> >>> >>> > > > -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html