Em 21-12-2009 01:44, Andy Walls escreveu:
> On Sun, 2009-12-20 at 22:33 -0500, Devin Heitmueller wrote:
>> On Sun, Dec 20, 2009 at 10:28 PM, Andy Walls <awa...@radix.net> wrote:
>>> Hmmm on the current v4l-dvb tree, the command
>>>
>>> $ v4l/scripts/checkpatch.pl --no-tree --strict \
>>> -f linux/drivers/media/video/cx18/cx18-driver.c
>>>
>>> yields warnings about pre-existing >80 column lines and
>>> LINUX_VERSION_CODE checks.
>>>
>>> Was there something else?
>>
>> No, that's what I'm talking about. I figured if you wanted to split
>> the CX18_ERR messages to fit on 80 columns, that is really at your
>> discretion, not mine. I can certainly do it, of course, but I
>> personally believe it's one of those cases where it is better to not
>> split them.
>
> Ah. No I wouldn't bother. The LKML has some churn on checkpatch's 80
> column warning in the past few days:
The 80 cols is just a warning. It is useful basically to point places where
perhaps the logic is being too complex (for example, cases where there are
several loops inside).
In the case of this patch series, the complains are not related to 80 cols:
cx18-alsa: Initial non-working cx18-alsa files
ERROR: need consistent spacing around '+' (ctx:WxV)
#124: FILE: linux/drivers/media/video/cx18/cx18-alsa-mixer.c:95:
+ uinfo->value.integer.max = +8;
^
total: 1 errors, 0 warnings, 579 lines checked
/tmp/newpatches/hg_hvr-1600-alsa-2_02.patch:
cx18-alsa: Add non-working cx18-alsa-pcm.[ch] files to avoid data loss
/tmp/newpatches/hg_hvr-1600-alsa-2_04.patch:
cx18: make it so cx18-alsa-main.c compiles
WARNING: line over 80 characters
#44: FILE: linux/drivers/media/video/cx18/cx18-alsa-main.c:44:
+#define CX18_DEBUG_ALSA_INFO(fmt, arg...) printk(KERN_INFO "%s: " fmt,
"cx18-alsa", ## arg)
WARNING: printk() should include KERN_ facility level
#89: FILE: linux/drivers/media/video/cx18/cx18-alsa-main.c:254:
+ printk("cx18-alsa: drv was null\n");
total: 0 errors, 2 warnings, 74 lines checked
/tmp/newpatches/hg_hvr-1600-alsa-2_06.patch:
cx18: overhaul ALSA PCM device handling so it works
WARNING: externs should be avoided in .c files
#41: FILE: linux/drivers/media/video/cx18/cx18-alsa-pcm.c:40:
+extern int cx18_alsa_debug;
WARNING: externs should be avoided in .c files
#50: FILE: linux/drivers/media/video/cx18/cx18-alsa-pcm.c:49:
+void cx18_alsa_announce_pcm_data(struct snd_cx18_card *cxsc, u8 *pcm_data,
WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version
to which it is merged
#53: FILE: linux/drivers/media/video/cx18/cx18-alsa-pcm.c:52:
+#if LINUX_VERSION_CODE <= KERNEL_VERSION(2, 6, 16)
WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version
to which it is merged
#162: FILE: linux/drivers/media/video/cx18/cx18-alsa-pcm.c:164:
+#if LINUX_VERSION_CODE <= KERNEL_VERSION(2, 6, 16)
WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version
to which it is merged
#169: FILE: linux/drivers/media/video/cx18/cx18-alsa-pcm.c:171:
+#if LINUX_VERSION_CODE <= KERNEL_VERSION(2, 6, 16)
WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version
to which it is merged
#232: FILE: linux/drivers/media/video/cx18/cx18-alsa-pcm.c:240:
+#if LINUX_VERSION_CODE <= KERNEL_VERSION(2, 6, 16)
WARNING: line over 80 characters
#361: FILE: linux/drivers/media/video/cx18/cx18-alsa-pcm.c:389:
+ snd_pcm_set_ops(sp, SNDRV_PCM_STREAM_CAPTURE,
&snd_cx18_pcm_capture_ops);
total: 0 errors, 7 warnings, 396 lines checked
/tmp/newpatches/hg_hvr-1600-alsa-2_10.patch:
cx18: rework cx18-alsa module loading to support automatic loading
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#100: FILE: linux/drivers/media/video/cx18/cx18-driver.c:52:
+EXPORT_SYMBOL(cx18_ext_init);
WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version
to which it is merged
#131: FILE: linux/drivers/media/video/cx18/cx18-driver.c:1220:
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,20)
ERROR: space required after that ',' (ctx:VxV)
#131: FILE: linux/drivers/media/video/cx18/cx18-driver.c:1220:
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,20)
^
ERROR: space required after that ',' (ctx:VxV)
#131: FILE: linux/drivers/media/video/cx18/cx18-driver.c:1220:
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,20)
^
ERROR: spaces required around that '=' (ctx:VxV)
#138: FILE: linux/drivers/media/video/cx18/cx18-driver.c:1227:
+ struct cx18 *dev=container_of(work, struct cx18, request_module_wk);
^
WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version
to which it is merged
#151: FILE: linux/drivers/media/video/cx18/cx18-driver.c:1240:
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,20)
ERROR: space required after that ',' (ctx:VxV)
#151: FILE: linux/drivers/media/video/cx18/cx18-driver.c:1240:
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,20)
^
ERROR: space required after that ',' (ctx:VxV)
#151: FILE: linux/drivers/media/video/cx18/cx18-driver.c:1240:
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,20)
^
ERROR: "(foo*)" should be "(foo *)"
#152: FILE: linux/drivers/media/video/cx18/cx18-driver.c:1241:
+ INIT_WORK(&dev->request_module_wk, request_module_async, (void*)dev);
total: 6 errors, 3 warnings, 150 lines checked
/tmp/newpatches/hg_hvr-1600-alsa-2_17.patch:
cx18: codingstyle fixes
WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version
to which it is merged
#37: FILE: linux/drivers/media/video/cx18/cx18-driver.c:1221:
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 20)
WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version
to which it is merged
#55: FILE: linux/drivers/media/video/cx18/cx18-driver.c:1241:
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 20)
total: 0 errors, 2 warnings, 44 lines checked
Cheers,
Mauro.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
