Em 15-06-2011 23:30, Kassey Lee escreveu: > 2011/6/14 Jonathan Corbet <cor...@lwn.net>: >> On Tue, 14 Jun 2011 10:58:47 +0800 >> Kassey Lee <kassey1...@gmail.com> wrote: >>>> + /* >>>> + * Try to find the sensor. >>>> + */ >>>> + cam->sensor_addr = ov7670_info.addr; >>>> + cam->sensor = v4l2_i2c_new_subdev_board(&cam->v4l2_dev, >>>> + &cam->i2c_adapter, &ov7670_info, NULL); >>> I do not thinks so. >> >> I don't understand what this comment is meant to mean...? > this should be move out to arch/arm/mach-xxx/board.c
Please drop the parts that you're not commenting. It is very hard to find a one-line comment in the middle of a long patch, especially since you don't even add blank lines before/after it. With respect to your comment, it doesn't makes much sense,as cafe_ccic runs on OLPC 1 hardware (at least the version I have here) is x86-based. So, I'm not seeing any reason why not apply patch 2/8. Applying on my tree. Mauro. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
