On Wed, Oct 2, 2019 at 4:49 PM Vishal Verma <[email protected]> wrote: > > Add a new '--no-movable' option to daxctl commands that may online > memory - i.e. daxctl-reconfigure-device and daxctl-online-memory. > > Users may wish additional control over the state of the newly added > memory. Retain the daxctl default for onlining memory as 'movable', but > allow it to be overridden using the above option. > > Link: https://github.com/pmem/ndctl/issues/110 > Cc: Ben Olson <[email protected]> > Cc: Dave Hansen <[email protected]> > Cc: Dan Williams <[email protected]> > Signed-off-by: Vishal Verma <[email protected]> > --- > Documentation/daxctl/daxctl-online-memory.txt | 2 ++ > .../daxctl/daxctl-reconfigure-device.txt | 2 ++ > Documentation/daxctl/movable-options.txt | 10 ++++++ > daxctl/device.c | 34 ++++++++++++++++--- > 4 files changed, 44 insertions(+), 4 deletions(-) > create mode 100644 Documentation/daxctl/movable-options.txt > > diff --git a/Documentation/daxctl/daxctl-online-memory.txt > b/Documentation/daxctl/daxctl-online-memory.txt > index 5ac1cbf..08b45cc 100644 > --- a/Documentation/daxctl/daxctl-online-memory.txt > +++ b/Documentation/daxctl/daxctl-online-memory.txt > @@ -62,6 +62,8 @@ OPTIONS > more /dev/daxX.Y devices, where X is the region id and Y is the device > instance id. > > +include::movable-options.txt[] > + > -u:: > --human:: > By default the command will output machine-friendly raw-integer > diff --git a/Documentation/daxctl/daxctl-reconfigure-device.txt > b/Documentation/daxctl/daxctl-reconfigure-device.txt > index 4663529..cb28fed 100644 > --- a/Documentation/daxctl/daxctl-reconfigure-device.txt > +++ b/Documentation/daxctl/daxctl-reconfigure-device.txt > @@ -135,6 +135,8 @@ OPTIONS > brought online automatically and immediately with the 'online_movable' > policy. Use this option to disable the automatic onlining behavior. > > +include::movable-options.txt[] > + > -f:: > --force:: > When converting from "system-ram" mode to "devdax", it is expected > diff --git a/Documentation/daxctl/movable-options.txt > b/Documentation/daxctl/movable-options.txt > new file mode 100644 > index 0000000..0ddd7b6 > --- /dev/null > +++ b/Documentation/daxctl/movable-options.txt > @@ -0,0 +1,10 @@ > +// SPDX-License-Identifier: GPL-2.0 > + > +-M:: > +--no-movable::
If --movable is the default I would expect -M to be associated with --movable. Don't we otherwise get the --no-<option> handling for free with boolean options? I otherwise don't think we need a short option for the "no" case. _______________________________________________ Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]
