Hi Jacopo, Thank you for the patch.
On Wednesday, 5 September 2018 18:29:43 EEST Jacopo Mondi wrote: > From: Koji Matsuoka <koji.matsuoka...@renesas.com> > > Add device nodes for VIN4, VIN5 and CSI40 to R-Car E3 R8A77990 device tree. > > Signed-off-by: Koji Matsuoka <koji.matsuoka...@renesas.com> > Signed-off-by: Takeshi Kihara <takeshi.kihara...@renesas.com> > Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> > --- > arch/arm64/boot/dts/renesas/r8a77990.dtsi | 79 ++++++++++++++++++++++++++++ > 1 file changed, 79 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi > b/arch/arm64/boot/dts/renesas/r8a77990.dtsi index ae89260..0ae7bbe 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi > @@ -337,6 +337,85 @@ > status = "disabled"; > }; > > + csi40: csi2@feaa0000 { I believe Simon would like to keep the nodes sorted by address > + compatible = "renesas,r8a77990-csi2", > "renesas,rcar-gen3-csi2"; > + reg = <0 0xfeaa0000 0 0x10000>; 0x10000 seems pretty large to me. Apart from that, Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > + interrupts = <GIC_SPI 246 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 716>; > + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; > + resets = <&cpg 716>; > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@1 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + reg = <1>; > + > + csi40vin4: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&vin4csi40>; > + }; > + csi40vin5: endpoint@1 { > + reg = <1>; > + remote-endpoint = <&vin5csi40>; > + }; > + }; > + }; > + }; > + > + vin4: video@e6ef4000 { > + compatible = "renesas,vin-r8a77990"; > + reg = <0 0xe6ef4000 0 0x1000>; > + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 807>; > + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; > + resets = <&cpg 807>; > + renesas,id = <4>; > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@1 { > + reg = <1>; > + > + vin4csi40: endpoint { > + remote-endpoint= <&csi40vin4>; > + }; > + }; > + }; > + }; > + > + vin5: video@e6ef5000 { > + compatible = "renesas,vin-r8a77990"; > + reg = <0 0xe6ef5000 0 0x1000>; > + interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 806>; > + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; > + resets = <&cpg 806>; > + renesas,id = <5>; > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@1 { > + reg = <1>; > + > + vin5csi40: endpoint { > + remote-endpoint= <&csi40vin5>; > + }; > + }; > + }; > + }; > + > scif2: serial@e6e88000 { > compatible = "renesas,scif-r8a77990", > "renesas,rcar-gen3-scif", "renesas,scif"; -- Regards, Laurent Pinchart