On Tue, Oct 30, 2018 at 02:57:59PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > On Tuesday, 30 October 2018 12:14:31 EET jacopo mondi wrote: > > On Mon, Sep 10, 2018 at 05:12:30PM +0300, Laurent Pinchart wrote: > > > On Wednesday, 5 September 2018 18:29:43 EEST Jacopo Mondi wrote: > > >> From: Koji Matsuoka <[email protected]> > > >> > > >> Add device nodes for VIN4, VIN5 and CSI40 to R-Car E3 R8A77990 device > > >> tree. > > >> > > >> Signed-off-by: Koji Matsuoka <[email protected]> > > >> Signed-off-by: Takeshi Kihara <[email protected]> > > >> Signed-off-by: Jacopo Mondi <[email protected]> > > >> --- > > >> > > >> arch/arm64/boot/dts/renesas/r8a77990.dtsi | 79 ++++++++++++++++++++++++ > > >> 1 file changed, 79 insertions(+) > > >> > > >> diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi > > >> b/arch/arm64/boot/dts/renesas/r8a77990.dtsi index ae89260..0ae7bbe > > >> 100644 > > >> --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi > > >> +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi > > >> @@ -337,6 +337,85 @@ > > >> > > >> status = "disabled"; > > >> > > >> }; > > >> > > >> + csi40: csi2@feaa0000 { > > > > > > I believe Simon would like to keep the nodes sorted by address > > > > > >> + compatible = "renesas,r8a77990-csi2", > > >> "renesas,rcar-gen3-csi2"; > > >> + reg = <0 0xfeaa0000 0 0x10000>; > > > > > > 0x10000 seems pretty large to me. > > > > It seems to me that all Gen3 SoC have this lenght specified > > > > $git grep -A 10 'csi[2|4][0|1]: csi' arch/arm64/boot/dts/renesas/ | grep reg > > arch/arm64/boot/dts/renesas/r8a7795.dtsi- reg = <0 0xfea80000 0 0x10000>; > > arch/arm64/boot/dts/renesas/r8a7795.dtsi- reg = <0 0xfeaa0000 0 0x10000>; > > arch/arm64/boot/dts/renesas/r8a7795.dtsi- reg = <0 0xfeab0000 0 0x10000>; > > arch/arm64/boot/dts/renesas/r8a7796.dtsi- reg = <0 0xfea80000 0 0x10000>; > > arch/arm64/boot/dts/renesas/r8a7796.dtsi- reg = <0 0xfeaa0000 0 0x10000>; > > arch/arm64/boot/dts/renesas/r8a77965.dtsi- reg = <0 0xfea80000 0 0x10000>; > > arch/arm64/boot/dts/renesas/r8a77965.dtsi- reg = <0 0xfeaa0000 0 0x10000>; > > arch/arm64/boot/dts/renesas/r8a77970.dtsi- reg = <0 0xfeaa0000 0 0x10000>; > > arch/arm64/boot/dts/renesas/r8a77980.dtsi- reg = <0 0xfeaa0000 0 0x10000>; > > arch/arm64/boot/dts/renesas/r8a77980.dtsi- reg = <0 0xfeab0000 0 0x10000>; > > arch/arm64/boot/dts/renesas/r8a77990.dtsi- reg = <0 0xfeaa0000 0 0x10000>; > > > > Am I missing something? > > Cargo-cult programming ? :-) This will likely not hurt, but such a large > memory area is not required, and we'll save a bit of memory if we reduce the > mapping from 64kB to 4kB (or less)
Can we please update this patch, and existing dtsi files, to use an appropriately small register window? > > > > Apart from that, > > > > I will include the upporting of the following patch to fix the VIN > > endpoint numbering in forthcoming v3: > > https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas-bsp.git/commit > > /?id=1b1b73f7558d867d72e198901b84bec1e6ef1405 > > > > As this has already been applied to simon's tree. > > > > > Reviewed-by: Laurent Pinchart <[email protected]> > > > > > >> + interrupts = <GIC_SPI 246 IRQ_TYPE_LEVEL_HIGH>; > > >> + clocks = <&cpg CPG_MOD 716>; > > >> + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; > > >> + resets = <&cpg 716>; > > >> + status = "disabled"; > > >> + > > >> + ports { > > >> + #address-cells = <1>; > > >> + #size-cells = <0>; > > >> + > > >> + port@1 { > > >> + #address-cells = <1>; > > >> + #size-cells = <0>; > > >> + > > >> + reg = <1>; > > >> + > > >> + csi40vin4: endpoint@0 { > > >> + reg = <0>; > > >> + remote-endpoint = > > >> <&vin4csi40>; > > >> + }; > > >> + csi40vin5: endpoint@1 { > > >> + reg = <1>; > > >> + remote-endpoint = > > >> <&vin5csi40>; > > >> + }; > > >> + }; > > >> + }; > > >> + }; > > >> + > > >> + vin4: video@e6ef4000 { > > >> + compatible = "renesas,vin-r8a77990"; > > >> + reg = <0 0xe6ef4000 0 0x1000>; > > >> + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>; > > >> + clocks = <&cpg CPG_MOD 807>; > > >> + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; > > >> + resets = <&cpg 807>; > > >> + renesas,id = <4>; > > >> + status = "disabled"; > > >> + > > >> + ports { > > >> + #address-cells = <1>; > > >> + #size-cells = <0>; > > >> + > > >> + port@1 { > > >> + reg = <1>; > > >> + > > >> + vin4csi40: endpoint { > > >> + remote-endpoint= > > >> <&csi40vin4>; > > >> + }; > > >> + }; > > >> + }; > > >> + }; > > >> + > > >> + vin5: video@e6ef5000 { > > >> + compatible = "renesas,vin-r8a77990"; > > >> + reg = <0 0xe6ef5000 0 0x1000>; > > >> + interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_HIGH>; > > >> + clocks = <&cpg CPG_MOD 806>; > > >> + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; > > >> + resets = <&cpg 806>; > > >> + renesas,id = <5>; > > >> + status = "disabled"; > > >> + > > >> + ports { > > >> + #address-cells = <1>; > > >> + #size-cells = <0>; > > >> + > > >> + port@1 { > > >> + reg = <1>; > > >> + > > >> + vin5csi40: endpoint { > > >> + remote-endpoint= > > >> <&csi40vin5>; > > >> + }; > > >> + }; > > >> + }; > > >> + }; > > >> + > > >> scif2: serial@e6e88000 { > > >> compatible = "renesas,scif-r8a77990", > > >> "renesas,rcar-gen3-scif", > > >> "renesas,scif"; > > -- > Regards, > > Laurent Pinchart > > >
