Hi Bart, > -----Original Message----- > From: Bart Van Assche > Sent: Friday, August 10, 2018 2:51 AM > To: [email protected]; Avri Altman ; [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected] > Cc: Vinayak Holikatti ; Avi Shchislowski ; Alex Lemberg ; Stanislav Nijnikov > ; [email protected] > Subject: Re: [PATCH v2 1/8] scsi: Add ufs transport class > > On Thu, 2018-08-09 at 23:32 +0000, Avri Altman wrote: > > And as I said before, we think that maintaining the flexibility to have > > more-than-one > > bsg device nodes, will be useful serving as a testing and validation > > environment. > > That is a very vague statement. Please clarify. > > > >> "... > > >> In addition to the basic SCSI core objects this transport class > > >> introduces two additional (currently empty) class objects: > > >> “ufs-host” and “ufs-port”. There is only one “ufs-host” in the > > >> system, but can be more-than-one “ufs-ports”. > > >> > > >> ..." > > > > >Since both the ufs-host and ufs-port objects are empty, can both be left > > >out? > > But mustn't I declare those classes for the various components of the scsi > > transport to work? > > Are you perhaps referring to the transport_class_register() calls in SCSI > transport drivers? From what I see in existing SCSI transport drivers the > transport_class_register() function is used to register link, port, host, > vport, rport and other objects. I don't think that a SCSI transport driver > is required to register host and port objects. > > Maybe we should take a step back and discuss first why the new bsg queues > are registered by a transport driver? Since in case of UFS as far as I can > see there is no real need to introduce a transport driver other than for > creating the bsg device nodes, have you considered to add the code for > creating bsg device nodes to the UFS driver instead of in a UFS transport > driver? I think transport drivers were introduced as a way to share code > between multiple SCSI LLDs that use the same transport mechanism. In the > case of UFS there is only one SCSI LLD. Hence I'm wondering whether we > really need an UFS transport driver. >
At the moment, the SCSI transport related code could be found at driver/scsi/scsi_transport_* files. What is a point of hiding the UFS transport code inside the UFS driver? Regards. Stanislav
