On Tue, 2018-08-14 at 11:42 +0000, Stanislav Nijnikov wrote:
> From: Bart Van Assche
> > Are you perhaps referring to the transport_class_register() calls in SCSI
> > transport drivers? From what I see in existing SCSI transport drivers the
> > transport_class_register() function is used to register link, port, host,
> > vport, rport and other objects. I don't think that a SCSI transport driver
> > is required to register host and port objects.
> > 
> > Maybe we should take a step back and discuss first why the new bsg queues
> > are registered by a transport driver? Since in case of UFS as far as I can
> > see there is no real need to introduce a transport driver other than for
> > creating the bsg device nodes, have you considered to add the code for
> > creating bsg device nodes to the UFS driver instead of in a UFS transport
> > driver? I think transport drivers were introduced as a way to share code
> > between multiple SCSI LLDs that use the same transport mechanism. In the
> > case of UFS there is only one SCSI LLD. Hence I'm wondering whether we
> > really need an UFS transport driver.
> 
> At the moment, the SCSI transport related code could be found at 
> driver/scsi/scsi_transport_* files.
> What is a point of hiding the UFS transport code inside the UFS driver?  

Have you tried to implement the approach I proposed? If so, did you encounter
any issues that made it impossible to implement that approach? If you have
not yet tried to implement the above proposal, what are you waiting for?

Bart.


Reply via email to