Hi,
On 01/02/2014 02:09 AM, David Lanzendörfer wrote:
Hi Hans, Maxime et al,
I've made a first approach to incorporate the changes we've disscussed.
I'm not quite done yet.
You can have a look at it under:
http://git.o2s.ch/?p=linux-next.git;a=shortlog;h=refs/heads/20131224
My recent issue: I appear to be missing certain patchsets which haven't
been merged into linux-next yet. Mainly some subfunction for the clock.
I always get 0 when I try to round a clock frequency,
which of course makes testing of my code impossible.
It would be great if someone would take the time and would have a look
through the commitlog...
Or maybe Maxime?
Do you have an idea where the problem with clk_round_rate could come from?
Thanks for working on this. I've merged your updated version of the
patches into the sunxi-devel branch. That branch has several sunxi-clk
commits which are not in -next (and I don't know when they will be send
there, Emilio?).
With those patches your updated version of the mmc driver works fine for
me. I think it would be a good idea for you to use sunxi-devel as a base
for your work, you can just checkout:
https://github.com/linux-sunxi/linux-sunxi/commit/c213f86956991b20f847dca9846e7cd112032f67
As a start point for further work, that gives you all the bits I believe
to be headed for 3.14 + the few extra patches you need from Emilio + your
work sofar.
I've also taken a quick look at your patches, I've one remark about:
https://github.com/linux-sunxi/linux-sunxi/commit/796b36502919bd4327029d0f0b10180af279c72e
For newer soc models where the ip-block is unchanged you should use
the same compatible string as the first model with that version of the ip-block.
IOW for sun5i-a10s and sun7i-a20 the compatible string should be
"allwinner,sun5i-a13-mmc"
And more in general when making changes to the dts files, please do one commit
for each of sun4i, sun5i and sun7i, that will making squashing things together
later much easier.
Thanks & Regards,
Hans
p.s.
If you run out of time and/or steam please let me know and I can do a v2 of
this patch-set
if you want me to. In that case, I assume it is ok I add a
Signed-off-by: David Lanzendörfer <[email protected]>
to all the patches ?
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
