On Wed, Jun 19, 2019 at 1:17 AM Jernej Škrabec <[email protected]> wrote: > > Dne torek, 18. junij 2019 ob 19:13:16 CEST je Clément Péron napisal(a): > > Hi, > > > > On Thu, 16 May 2019 at 03:27, Andre Przywara <[email protected]> wrote: > > > The first USB controller on the H6 SoC shares a PHY with the OTG > > > controller. Reportedly to avoid problems with the VBUS regulator under > > > Linux, we don't link OHCI0/EHCI0 to the USB PHY in the H6 .dtsi file. > > > > > > However on boards which can't use peripheral mode (because they have an > > > always-on VBUS supply on an USB-A socket) we don't need this trick, and > > > can properly connect host controller 0 to the PHY 0. > > > > > > Amend the Pine H64 .dts to reflect this. This enables the upper USB port > > > in U-Boot on this board. > > > > > > Signed-off-by: Andre Przywara <[email protected]> > > > --- > > > > > > arch/arm/dts/sun50i-h6-pine-h64.dts | 5 ++++- > > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > > > diff --git a/arch/arm/dts/sun50i-h6-pine-h64.dts > > > b/arch/arm/dts/sun50i-h6-pine-h64.dts index 4802902e12..aad7646b18 100644 > > > --- a/arch/arm/dts/sun50i-h6-pine-h64.dts > > > +++ b/arch/arm/dts/sun50i-h6-pine-h64.dts > > > @@ -96,6 +96,8 @@ > > > > > > }; > > > > > > &ehci0 { > > > > > > + phys = <&usb2phy 0>; > > > + phy-names = "usb"; > > > > > > status = "okay"; > > > > > > }; > > > > > > @@ -120,6 +122,8 @@ > > > > > > }; > > > > > > &ohci0 { > > > > > > + phys = <&usb2phy 0>; > > > + phy-names = "usb"; > > > > > > status = "okay"; > > > > > > }; > > > > > > @@ -255,7 +259,6 @@ > > > > > > &usb2otg { > > > > > > dr_mode = "host"; > > > > > > - status = "okay"; > > > > > > }; > > > > Maybe you should add explicit comments in the device-tree to avoid > > losing this at next sync with linux dt. > > If DT change is U-Boot specific, it should be moved to *-u-boot.dtsi file, > although I'm not sure if you can delete properties in such way.
You can use /delete-property/. Though in the case of "status", it is best to set it to "disabled", since no property is the same as "okay". The question then becomes when the *-u-boot.dtsi file is merged in. ChenYu -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/CAGb2v67ipGQ%2BPHK5%2B24HwMgQ9-NnFj98-dv%2BqSXOnCyZifQuaw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
