On 05.03.25 20:30, Matthew Wilcox wrote:
On Tue, Mar 04, 2025 at 04:48:46PM +0100, David Hildenbrand wrote:+static bool orig_page_is_identical(struct vm_area_struct *vma, + unsigned long vaddr, struct page *page, bool *pmd_mappable) +{ + const pgoff_t index = vaddr_to_offset(vma, vaddr) >> PAGE_SHIFT; + struct page *orig_page = find_get_page(vma->vm_file->f_inode->i_mapping, + index); + struct folio *orig_folio; + bool identical; + + if (!orig_page) + return false; + orig_folio = page_folio(orig_page);I'd rather write this as: struct folio *orig_folio = filemap_get_folio(vma->vm_file->f_mapping, index); struct page *orig_page; if (IS_ERR(orig_folio)) return false; orig_page = folio_file_page(folio, index);
Willy, you read my mind. I was staring at that code and thought "there must be an easier way using pages", and folio_file_page() was the missing piece.
Thanks! -- Cheers, David / dhildenb
