On 10/20/25 22:41, Johannes Thumshirn wrote: > Add definitions for the extended version of the blktrace protocol using a > wider action type to be able to record new actions in the kernel. > > Reviewed-by: Christoph Hellwig <[email protected]> > Signed-off-by: Johannes Thumshirn <[email protected]>
One nit below. Reviewed-by: Damien Le Moal <[email protected]> > +struct blk_io_trace2 { > + __u32 magic; /* MAGIC << 8 | BLK_IO_TRACE2_VERSION */ > + __u32 sequence; /* event number */ > + __u64 time; /* in nanoseconds */ > + __u64 sector; /* disk offset */ > + __u32 bytes; /* transfer length */ > + __u32 pid; /* who did it */ > + __u64 action; /* what happened */ > + __u32 device; /* device number */ > + __u32 cpu; /* on what cpu did it happen */ > + __u16 error; /* completion error */ > + __u16 pdu_len; /* length of data after this trace */ > + __u8 pad[12]; > + /* cgroup id will be stored here if exists */ s/if exists/if it exists -- Damien Le Moal Western Digital Research
