On 10/20/25 22:41, Johannes Thumshirn wrote: > Differentiate between blk_io_trace and blk_io_trace2 when relaying to > user-space depending on which version has been requested by the blktrace > utility. > > Reviewed-by: Christoph Hellwig <[email protected]> > Signed-off-by: Johannes Thumshirn <[email protected]>
One nit below. Reviewed-by: Damien Le Moal <[email protected]> > @@ -146,8 +202,8 @@ static void trace_note(struct blk_trace *bt, pid_t pid, > u64 action, > if (!bt->rchan) > return; > > - relay_blktrace_event(bt, 0, pid, cpu, 0, 0, action, 0, cgid, > - cgid_len, (void *)data, len); > + relay_blktrace_event(bt, 0, pid, cpu, 0, 0, action, 0, cgid, cgid_len, > + (void *)data, len); You are not changing anything here, so this is just churn... Not a huge problem, but not needed. > } > > /* -- Damien Le Moal Western Digital Research
