On Tue, 2025-11-25 at 14:57 -0500, Steven Rostedt wrote: > On Mon, 17 Nov 2025 09:06:02 +0000 > Nam Cao <[email protected]> wrote: > > > @@ -644,13 +640,11 @@ static ssize_t enabled_monitors_write(struct file > > *filp, const char __user *user > > else > > retval = rv_disable_monitor(mon); > > > > - if (!retval) > > - retval = count; > > - > > - break; > > + if (retval) > > + return retval; > > + return count; > > No biggy, but I wonder if this would look better as: > > return retval ? : count; >
Tried both patches and they look fine to me. Reviewed-by: Gabriele Monaco <[email protected]> Nam, feel free to send an updated version if you want to apply Steve's suggestion or keep the patch like this. Steve, this is the only remaining change before the merge window, unless you prefer to keep it for the next round, I'm going to send a small pull requests with those two patches alone. Thanks, Gabriele > -- Steve > > > } > > > > - mutex_unlock(&rv_interface_lock); > > return retval; > > } > >
