On Fri, May 22, 2026 at 11:28:10PM +0200, Jiri Olsa wrote: > On Fri, May 22, 2026 at 11:52:56AM -0700, Andrii Nakryiko wrote: > > On Thu, May 21, 2026 at 5:45 AM Jiri Olsa <[email protected]> wrote: > > > > > > We now expect nop combo with 10 bytes nop instead of 5 bytes nop, > > > fixing has_nop_combo to reflect that. > > > > > > Fixes: 41a5c7df4466 ("libbpf: Add support to detect nop,nop5 instructions > > > combo for usdt probe") > > > Reviewed-by: Jakub Sitnicki <[email protected]> > > > Signed-off-by: Jiri Olsa <[email protected]> > > > --- > > > tools/lib/bpf/usdt.c | 16 ++++++++-------- > > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > > > diff --git a/tools/lib/bpf/usdt.c b/tools/lib/bpf/usdt.c > > > index e3710933fd52..484a4354e82b 100644 > > > --- a/tools/lib/bpf/usdt.c > > > +++ b/tools/lib/bpf/usdt.c > > > @@ -305,7 +305,7 @@ struct usdt_manager *usdt_manager_new(struct > > > bpf_object *obj) > > > > > > /* > > > * Detect kernel support for uprobe() syscall, it's presence > > > means we can > > > - * take advantage of faster nop5 uprobe handling. > > > + * take advantage of faster nop10 uprobe handling. > > > * Added in: 56101b69c919 ("uprobes/x86: Add uprobe syscall to > > > speed up uprobe") > > > > Would be nice to add commit that switches nop5 to nop10 (but until it > > lands hash is not stable, so, hmmm, maybe we'll land this patch > > separately? send it a bit later to bpf-next?) > > hm, I think that would affect the subtest_optimized_attach usdt test > which depend on this behaviour, will check
usdt/optimized_attach will fail without this change, I'll make note to update it later when we have the hash jirka
