On Tue, 4 Aug 2026 12:23:07 +0100
Fuad Tabba <[email protected]> wrote:
> trace_remote_event.h uses bool without including linux/types.h, so a
> translation unit that includes it ahead of anything else that pulls
> types.h in fails to build, as with nvhe/trace.h at EL2.
>
> Fixes: 072529158e60 ("tracing: Add events to trace remotes")
> Acked-by: Steven Rostedt <[email protected]>
> Signed-off-by: Fuad Tabba <[email protected]>
> ---
> include/linux/trace_remote_event.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/trace_remote_event.h
> b/include/linux/trace_remote_event.h
> index c8ae1e1f5e721..e4cc2d4497bcf 100644
> --- a/include/linux/trace_remote_event.h
> +++ b/include/linux/trace_remote_event.h
> @@ -3,6 +3,8 @@
> #ifndef _LINUX_TRACE_REMOTE_EVENTS_H
> #define _LINUX_TRACE_REMOTE_EVENTS_H
>
> +#include <linux/types.h>
> +
> struct trace_remote;
> struct trace_event_fields;
> struct trace_seq;
My ack still stands, but I wonder if we should just not use the include and
instead s/bool/_Bool/ ?
-- Steve
