From: Masami Hiramatsu (Google) <[email protected]> Add a new ftracetest test case (filter-syntax-check.tc) to verify valid event filter expressions, error_log caret reporting for malformed filter expressions (empty filters, missing fields, unbalanced parentheses and quotes, dangling logical operators, invalid fields/values/cpulists), newline truncation on multi-line filter input, and error returns on invalid subsystem filters.
Signed-off-by: Masami Hiramatsu (Google) <[email protected]> --- Changes in v3: - Replace negated pipelines (! cmd) with explicit "if cmd; then exit_fail; fi" checks to properly catch unexpected success under POSIX sh with set -e. - Add test cases for empty string matching (prev_comm == "", prev_comm ~ ""). - Add test cases for out-of-range CPU IDs with CPUS{} comparison. - Add test cases for missing operands after operators. - Add test cases for empty operands and stray operators. - Add test cases for operand type mismatches and brace errors. - Add test cases for function event filter syntax checks (including INVALID_OP and ILLEGAL_FIELD_OP caret checks). - Add test cases for multi-line input validation on event and subsystem filters. --- .../ftrace/test.d/filter/filter-syntax-check.tc | 100 ++++++++++++++++++++ 1 file changed, 100 insertions(+) create mode 100644 tools/testing/selftests/ftrace/test.d/filter/filter-syntax-check.tc diff --git a/tools/testing/selftests/ftrace/test.d/filter/filter-syntax-check.tc b/tools/testing/selftests/ftrace/test.d/filter/filter-syntax-check.tc new file mode 100644 index 000000000000..02fb2be6e6eb --- /dev/null +++ b/tools/testing/selftests/ftrace/test.d/filter/filter-syntax-check.tc @@ -0,0 +1,100 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 +# description: event filter - test filter syntax error check +# requires: set_event events/sched/sched_switch/filter error_log +# flags: instance + +check_error() { # command-with-error-pos-by-^ + ftrace_errlog_check 'event filter parse error' "$1" 'events/sched/sched_switch/filter' +} + +# Valid filter expressions +echo '(common_pid == 0)' > events/sched/sched_switch/filter +echo '((common_pid == 0) && (prev_pid == 0))' > events/sched/sched_switch/filter +echo 'prev_comm ~ "*sh"' > events/sched/sched_switch/filter +echo 'prev_comm ~ "*"' > events/sched/sched_switch/filter +echo 'prev_comm == ""' > events/sched/sched_switch/filter +echo 'prev_comm ~ ""' > events/sched/sched_switch/filter +echo 'common_pid == CPUS{0}' > events/sched/sched_switch/filter +echo 'common_pid != CPUS{0}' > events/sched/sched_switch/filter +echo 0 > events/sched/sched_switch/filter + +# Empty or meaningless filter expressions +check_error '^()' # NO_FILTER +check_error '^== 1' # INVALID_FILTER +check_error 'common_pid ==^' # INVALID_FILTER +check_error 'common_pid !=^' # INVALID_FILTER +check_error 'common_pid >=^' # INVALID_FILTER + +# Unbalanced parentheses and quotes +check_error '^(common_pid == 1' # TOO_MANY_OPEN +check_error 'common_pid == 1^)' # TOO_MANY_CLOSE +check_error 'prev_comm == ^"bash' # MISSING_QUOTE + +# Dangling logical operators and empty operands +check_error 'common_pid == 1 &&^' # TOO_MANY_PREDS +check_error 'common_pid == 1 ||^' # TOO_MANY_PREDS +check_error 'common_pid == 1 || (common_pid == 2 && ^)' # INVALID_FILTER +check_error '(common_pid == ^)' # INVALID_VALUE +check_error 'common_pid == ^&& common_pid == 0' # INVALID_VALUE + +# Invalid field, operator, or operand type +check_error '^no_such_field == 1' # FIELD_NOT_FOUND +check_error 'common_pid == ^@' # INVALID_VALUE +check_error 'common_pid == ^"1"' # EXPECT_DIGIT +check_error 'prev_comm == ^0' # EXPECT_STRING +check_error 'common_pid ^~ 1' # ILLEGAL_FIELD_OP + +# CPUS{} syntax errors +check_error 'common_pid ^> CPUS{0}' # ILLEGAL_FIELD_OP +check_error 'common_pid == CPUS^0}' # MISSING_BRACE_OPEN +check_error 'common_pid == CPUS{0^' # MISSING_BRACE_CLOSE +check_error 'common_pid == CPUS{^}' # INVALID_CPULIST +check_error 'common_pid == CPUS{99999^}' # INVALID_CPULIST + +# Function event filter errors (if supported) +if [ -f events/kmem/kmem_cache_free/filter ]; then + check_kmem_error() { + ftrace_errlog_check 'event filter parse error' "$1" 'events/kmem/kmem_cache_free/filter' + } + check_kmem_error 'call_site.function == non_exist_func^' # NO_FUNCTION + check_kmem_error 'call_site.function ==^' # INVALID_FILTER + check_kmem_error 'call_site.function ^> 0' # INVALID_OP + check_kmem_error 'common_type^.function == 0' # ILLEGAL_FIELD_OP + echo 0 > events/kmem/kmem_cache_free/filter +fi + +# Multi-line input with non-whitespace characters after newline must fail +if ( printf "common_pid == 0\ncommon_pid == 1" | \ + dd of=events/sched/sched_switch/filter bs=4096 ) 2> /dev/null; then + exit_fail +fi +if ( printf "common_pid == CPUS{0\n\"} && common_pid == 0" | \ + dd of=events/sched/sched_switch/filter bs=4096 ) 2> /dev/null; then + exit_fail +fi + +# Trailing whitespace characters after newline are permitted +printf "common_pid == 0\n \n\t \n" | \ + dd of=events/sched/sched_switch/filter bs=4096 2> /dev/null +echo 0 > events/sched/sched_switch/filter + +# Subsystem filter must fail on invalid filter expressions +echo 'common_pid >= 0' > events/sched/filter +if echo 'no_such_field == 1' > events/sched/filter 2> /dev/null; then + exit_fail +fi +if echo 'common_pid == 1 &&' > events/sched/filter 2> /dev/null; then + exit_fail +fi +if ( printf "common_pid == 0\nfoo" | \ + dd of=events/sched/filter bs=4096 ) 2> /dev/null; then + exit_fail +fi + +# Subsystem filter with trailing whitespace after newline must succeed +printf "common_pid == 0\n \n\t \n" | \ + dd of=events/sched/filter bs=4096 2> /dev/null +echo 0 > events/sched/filter + +exit 0
