On Wed, 4 Jun 2003, David Brownell wrote:
Reads good, but some comments on the GET_STATUS requests:
- Those timeouts should be HZ * USB_CTRL_GET_TIMEOUT, these are excessively short.
- Naming is problematic: usb_*() suggests they're generic and exported, but they're not. I'd strike the usb_ prefix.
None of those are new issues, but they could be resolved now while this code is being updated.
What about the other static routines in hub.c that use the same prefix or the same short timeout?
More issues to address, yes ... :)
usb_get_hub_descriptor() usb_clear_hub_feature() usb_clear_port_feature() usb_set_port_feature() hub_clear_tt_buffer() usb_hub_power_on() usb_hub_configure() usb_hub_reset() usb_hub_disconnect() usb_hub_port_status() usb_hub_port_wait_reset() usb_hub_port_reset() usb_hub_port_debounce() usb_hub_port_connect_change() usb_hub_events() usb_hub_thread()
Shouldn't they all be changed?
I'd rather they were. The rename is purely a cosmetic change, but there's no good reason to have the hub driver use timeouts that are so much shorter than the rest of usbcore.
- Dave
Alan Stern
------------------------------------------------------- This SF.net email is sponsored by: Etnus, makers of TotalView, The best thread debugger on the planet. Designed with thread debugging features you've never dreamed of, try TotalView 6 free at www.etnus.com. _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
