On Sun, Aug 08, 2004 at 02:51:30PM +0200, Florian Echtler wrote:
> >Oh, so close, only a few minor issues:
> Fixed almost everything, see below.
>
> >Please place this in the proper, sorted order. Same with the Kconfig
> >and other Makefile.
> I placed it in the proper place in the Makefiles (and did that with
> the PHIDGETSERVO entries, too, they were also out of order). However,
> I really couldn't recognize any sort order in the Kconfig..
>
> >Which version of the license?
> >No copyright notice?
> Done.
Huh? This isn't a valid copyright notice:
> + Copyright by: Florian 'Floe' Echtler <echtler AT fs.tum.de>
> + Andreas 'ad' Deresch <aderesch AT fs.tum.de>
A valid copyright notice needs to have the date, and the (c) symbol.
Something like:
Copyright (c) 2004 Florian 'Floe' Echtler <echtler AT fs.tum.de>
Copyright (c) 2004 Andreas 'ad' Deresch <aderesch AT fs.tum.de>
It is also common manners to state where the code was based off of (in
this case, the usb-skeleton.c driver, right?), and who wrote that.
And what's with the "AT" stuff? Your full email address is already in
the file for the MODULE_AUTHOR() stuff :)
One last thing, I couldn't apply the patch, as it had some lines that
were wrapped. Please check your mailer and fix it from doing such
things.
thanks,
greg k-h
-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
