Hi Lothar, Do you accept patches for 1160-specific additions for 1362 code? Or should I keep my changes as a separate patch for now?
It would be also great to hear, what are your plans about the rest of the 1362 code (on top of ohci-1362.h). This usb stuff is really new to me and I feel it would take still quite some time before I would be able to implement anything sanely. Therefore I would be happy to test your code as soon as you have something. I found some more little bugs in ohci-1362.h and I will send you a patch with fixes. Just a question. In the macro definitions for accessing the PTD bitfields, you SET bitfields using elements of struct as macro parameters and GET bitfields using struct itself. Like this: #define PTD_LEN(v) FInsrt(v, _PTD_LEN) #define PTD_GET_LEN(p) FExtr(*(u16*)(&(p)->len), _PTD_LEN) What about changing the SET macros also to take struct: #define PTD_LEN(p) FInsrt(*(u16*)(&(p)->len, _PTD_LEN) > - Depending on the hardware you have you may or may not need to split > up 32 bit register accesses into two 16bit accesses to the same > address. '#define CAN_USE_32BIT 0' takes care of this Yes, this is of use on 1160. Olav ------------------------------------------------------- This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170 Project Admins to receive an Apple iPod Mini FREE for your judgement on who ports your project to Linux PPC the best. Sponsored by IBM. Deadline: Sept. 13. Go here: http://sf.net/ppc_contest.php _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
