Hi Olav, > Do you accept patches for 1160-specific additions for 1362 > code? Or should I keep my changes as a separate patch for > now? > Yes. No. ;) I would like to keep the code as general as possible, so everything what's platform or chip dependent should be clearly separated from the generic stuff. For this it will be very helpful to see what has to be done different on different hardware. So, go ahead and send your patches.
> It would be also great to hear, what are your plans about > the rest of the 1362 code (on top of ohci-1362.h). This usb > I could post them here as soon as I've got anything sensible working. But it might be more sensible to set up a common CVS repository? > stuff is really new to me and I feel it would take still > quite some time before I would be able to implement anything > sanely. Therefore I would be happy to test your code > as soon as you have something. > At least I've got my hardware now. I didn't have any success in accessing the chip though. :( > I found some more little bugs in ohci-1362.h and I will send > you a patch with fixes. Just a question. In the macro > OK, I'm awaiting your patches. > definitions for accessing the PTD bitfields, you SET > bitfields using elements of struct as macro parameters and > GET bitfields using struct itself. Like this: > > #define PTD_LEN(v) FInsrt(v, _PTD_LEN) > #define PTD_GET_LEN(p) FExtr(*(u16*)(&(p)->len), _PTD_LEN) > > What about changing the SET macros also to take struct: > > #define PTD_LEN(p) FInsrt(*(u16*)(&(p)->len, _PTD_LEN) > I didn't define any PTD_SET macros, because I prefer something like: ptd->ep_spd = PTD_EP(ed_en(ed_flags)) | PTD_LAST_ISO(last) | PTD_SPD(spd) | PTD_MPS_H(mps); over: PTD_SET_EP(ptd, ed_en(ed_flags)); PTD_SET_LAST_ISO(ptd, last); PTD_SET_SPD(ptd, spd); ... But we can also add the macros for setting individual fields of a PTD header. Lothar Wassmann ------------------------------------------------------- This SF.Net email is sponsored by: thawte's Crypto Challenge Vl Crack the code and win a Sony DCRHC40 MiniDV Digital Handycam Camcorder. More prizes in the weekly Lunch Hour Challenge. Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
