On Mon, Jan 24, 2005 at 09:45:03PM -0800, Randy.Dunlap wrote:
>
> Fix uhci to build with PROC_FS=n.
> However, I'm not sure about the patch.
> Does all of this go into debugfs now, instead of into procfs?
>
> Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]>
>
> diffstat:=
> drivers/usb/host/uhci-debug.c | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff -Naurp ./drivers/usb/host/uhci-debug.c~uhci_debugfs
> ./drivers/usb/host/uhci-debug.c
> --- ./drivers/usb/host/uhci-debug.c~uhci_debugfs 2005-01-22
> 19:06:31.214537776 -0800
> +++ ./drivers/usb/host/uhci-debug.c 2005-01-24 20:41:06.628150784 -0800
> @@ -34,6 +34,7 @@ static inline void lprintk(char *buf)
> }
> }
>
> +#ifdef CONFIG_DEBUG_FS
> static int uhci_show_td(struct uhci_td *td, char *buf, int len, int space)
> {
> char *out = buf;
> @@ -194,7 +195,6 @@ out:
> out += sprintf(out, "- Frame %d\n", i); \
> }
>
> -#ifdef CONFIG_PROC_FS
> static const char *qh_names[] = {
> "skel_int128_qh", "skel_int64_qh",
> "skel_int32_qh", "skel_int16_qh",
> @@ -497,8 +497,6 @@ static int uhci_sprint_schedule(struct u
>
> #define MAX_OUTPUT (64 * 1024)
>
> -static struct dentry *uhci_debugfs_root = NULL;
> -
> struct uhci_debug {
> int size;
> char *data;
> @@ -579,4 +577,7 @@ static struct file_operations uhci_debug
> .read = uhci_debug_read,
> .release = uhci_debug_release,
> };
> +
> +static struct dentry *uhci_debugfs_root = NULL;
> #endif
> +
Why do you need to move the uhci_debugfs_root variable, now that the
CONFIG_PROC_FS #ifdef was removed?
And I think you added another line to the end of the file :)
thanks,
greg k-h
-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
