Alan Stern wrote:
On Mon, 24 Jan 2005, Randy.Dunlap wrote:
Fix uhci to build with PROC_FS=n.
However, I'm not sure about the patch.
Does all of this go into debugfs now, instead of into procfs?
Your question has a trick answer. Yes, it goes into debugfs now instead
of procfs. But no, not all of it does. Some of the output can go into
the system log instead. This can happen when uhci_result_control (and
also uhci_result_bulk, if the "#if 0" line is removed) calls uhci_show_qh.
So it's correct to change #ifdef CONFIG_PROC_FS to #ifdef CONFIG_DEBUG_FS,
but you should leave it in the same place instead of moving it to the head
of the source file.
OK, will you make that change, please?
As for the uhci_debugfs_root declaration, there's no reason to move it to
the end.
Yes, I realized that after I sent it last night. It was just the
first error encountered and so the first change that I made, then
I never undid it.
--
~Randy
-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
