On Tue, Aug 12, 2008 at 11:57 PM, Tim Yamin <[EMAIL PROTECTED]> wrote: > On Tue, Aug 12, 2008 at 6:30 PM, Daniel Schnell > <[EMAIL PROTECTED]> wrote: >> Hi Tim, >> >> Continuing the discussion on the mailing list ... >> >> Looking at the original patch I don't undestand why you had to duplicate >> the bestcomm data structures and functions. The only apparent difference >> is that you have a minimal data length of 2 bytes instead of 1. Does >> this make any difference as the bd_size will be filled with the correct >> length value anyway ? > > The "new" version of the patch does this the correct way. I just > haven't back ported this to the 2.6.24 version that I sent you.
While on this topic; have you had a chance to address the comments you received on v2 of your patch? I'm keen to get your change merged in, but there are a few more things that need to be sorted out. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev