On 08/03/18 04:39, Richard Cochran wrote:
but is used in various places that care about the internal time
representation. Move this definition to tmv.h as a more natural home.
I'm not taking this patch because a) its not technically needed and b)
I disagree about what is more natural.
The idea behind the header files is:
- pdt.h Primitive data types according to 1588
- ddt.h Derived data types (1588)
- ds.h Data sets (1588)
- msg.h Message types
- tmv.h Internal time value representation
The message structure includes the protocol fields, the src/dst
address (if any), the TLVs, and the time stamp as provided by the
networking stack. The HW time stamp is intimately connected to the
message data, and so that is where the data structure belongs, IMHO.
OK. From memory, this patch was required to solve a circular dependency
that would otherwise appear in a subsequent patch. I'll recheck.
Michael
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
