On 08/03/18 04:46, Richard Cochran wrote:
On Thu, Mar 01, 2018 at 06:12:27PM +0000, Michael Brown wrote:
Add converters between hardware timestamps and the internal
representation, and remove code that directly manipulates the timespec
within a hardware timestamp.
Although I can see the point of this, still I really dislike this
patch. The method names are icky: hwts_sw_to_tmv? Also, it changes
too much at once for my taste.
I'm happy to rework to more granular patches.
Can you give me some idea of what names will be acceptable? I was
trying to fit within the current naming scheme as closely as possible,
but I'm very happy to redo it with whatever names you prefer.
If new, high resolution time stamps will be coming from the kernel,
then we definitely will need a better abstraction. But we should talk
about what that new form will look like first.
I was hoping to get your input on that anyway. :)
One idea is to extend struct scm_timestamping to append a fractional
nanosecond field for the hardware timestamp only. This would produce a
layout that is backwards compatible with older userspace, which would
simply ignore the fractional part (assuming that it does a
minimum-length rather than exact-length check on cmsg_len).
Does this sound sensible?
Thanks,
Michael
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
