Hi Richard, Hi Geva, I already tried "set MasteOnly" patch, except the slaveOnly missing check, and it seems to work.
Generally speaking and in my opinion should be interesting to have the following features: - asynchronous clock adjust: I2c is a slow bus with unpredictable access time, especially when you have a lot of devices. this is a true story. - a thread for each port that handles the ptp protocol and the timeouts: this will make more robust the stack on issues depending on TX timestamping. - a capability to use transport/interfaces different from linux interfaces, loading a custom .so file. i.e. timestamper send back the TS using in band communication. - ability to add/remove ports on the fly without traffic hit. - ability to change all port configurable parameters on the fly. My wishlist is from customer requirements, of course. I think that for longtime development should consider these improvements. ciao luigi Il giorno gio 22 apr 2021 alle ore 17:00 Richard Cochran < richardcoch...@gmail.com> ha scritto: > On Thu, Apr 22, 2021 at 01:35:11PM +0000, Geva, Erez wrote: > > You need to verify the ptp4l can dynamically change the master only flag. > > +1 > > > As the 'slave only' flag does not allow set, I skip it for now. > > Right, and it wouldn't work if added naively. > > > Only priorities 1 and 2 can be changed at the moment. > > They do work dynamically. > > > However as the 'master only' is a port action and not clock action as > 'slave only', it might be easier to implement and verify. > > Right, many of the SET actions would require re-initializing the > stack, but this isn't trivial to implement. I tried adding more SET > actions some time ago, but I soon ran into corner cases in the code > that spoiled everything. It is one of the weaknesses of linuxptp. > > As practical matter, in my own projects I simply re-start the start > when the configuration changes. Although not ideal, that is easier > than re-working linuxptp to properly handle each dynamic variable. > > Sorry, > Richard > -- *Luigi 'Comio' Mantellini* My Professional Profile <http://www.linkedin.com/in/comio> *"UNIX is very simple, it just needs a genius to understand its simplicity." [cit.]*
_______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
