On 26/04/2021 00:47, Richard Cochran wrote: > On Thu, Apr 22, 2021 at 03:04:17PM +0200, Erez Geva wrote: > >> diff --git a/pmc.c b/pmc.c >> index a767c8a..00d6014 100644 >> --- a/pmc.c >> +++ b/pmc.c >> @@ -335,6 +335,11 @@ static void pmc_show(struct ptp_message *msg, FILE *fp) >> fprintf(fp, "TIMESCALE_PROPERTIES " >> IFMT "ptpTimescale %d", mtd->val & PTP_TIMESCALE ? 1 : >> 0); >> break; >> + case TLV_MASTER_ONLY: >> + mtd = (struct management_tlv_datum *) mgt->data; >> + fprintf(fp, "MASTER_ONLY " >> + IFMT "masterOnly %d", mtd->val); >> + break; > > These switch/case tables are in numeric order.
I was wonder what was the proper order. On configuration we use alephbet order. I tried my luck on that. I will order and send version 2. Erez > > Could you please put this entry between TLV_VERSION_NUMBER (0x200C) > and TLV_DELAY_MECHANISM (0x6000)? > > Ditto for the other tables. > >> case TLV_TIME_STATUS_NP: >> tsn = (struct time_status_np *) mgt->data; >> fprintf(fp, "TIME_STATUS_NP " > > Thanks, > Richard > _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
