Jan, Is the Web Crypto/PKCS11 fork eventually intended to be merged in to master or is it meant to standalone as a true fork of the project? Openpgp.js has changed pretty dramatically since a lot of this was written and I think it will take a fair amount of work to get it into a mergeable state. So what is the intended plan with it moving forward?
Sean On Fri, Jan 3, 2014 at 1:13 PM, Crypto Stick <[email protected]> wrote: > Hi! > In September Peter Pentchev published his patch to add Web Crypto and > PKCS#11 device support to OpenPGPjs. See: > https://github.com/ppentchev/openpgpjs/tree/roam-webcrypto-master-owncrypto > > Since that time I hardly saw any feedback to him. It would be much > appreciated if somebody could review that patch and I would love to see > his patch in the master branch eventually. Thanks a lot! > > Regards, > Jan > > Am 03.01.2014 14:36, schrieb Tankred Hase: > > Hi everyone, > > > > great to see how the work on devel is progressing. Especially the > > documentation work by Robert and Thomas! > > > > There has been some discussions on github on how to procede with > > merging of devel into master. Considering that the current devel is a > > complete refactoring and the public api changed quite a bit, we would > > propose to rename the current master to a version branch named "v0.1". > > This is where legacy support can take place. > > > > The current devel branch will be renamed to "master" which will make > > it more obvious to new contributors where development is taking place. > > As we stabilize to v0.2, we can create a new branch for each version. > > That way we can provide api stability in each version branch but don't > > have to be afraid of breaking the public api as time goes by (at least > > until we commit to v1.0). > > > > Any thoughts/suggestions on this? > > > > As soon as I find the time, I will do some more detailed code review > > on the devel branch. If I understood correctly Robert will port the > > current unit tests to the mocha setup already running in travis CI. If > > everything looks good, We can commence with the branch renaming. > > > > Thanks > > Tankred > > _______________________________________________ > > > > http://openpgpjs.org > > Subscribe/unsubscribe: http://list.openpgpjs.org > > > _______________________________________________ > > http://openpgpjs.org > Subscribe/unsubscribe: http://list.openpgpjs.org >
_______________________________________________ http://openpgpjs.org Subscribe/unsubscribe: http://list.openpgpjs.org
