DavidSpickett wrote:
> Adjusting the lengths dynamically seems an okay change, but I agree with
> Jonas, the original justification was easier to read.
I agree that aligning the `=` is a good idea. Your downstream example is a good
justification of that.
I'm not so sure about left or right aligning the name, I think I agree with the
others that it should always be `<name><single space>=`, but I don't have a
scientific argument for it.
(one argument I can think of against it is that it's like a spreadsheet, so
everything would be left aligned within the columns)
Anyway, let's keep this PR to just the `=` change. You can always propose
things later if you want to.
Does this solution apply only to `register read` and `register read --all`?
What about this:
```
(lldb) register read x1 v1 pc
x1 = 0x0000fffffffff018
v1 = {0x2e 0x6f 0x00 0x4c 0x45 0x53 0x53 0x4f 0x50 0x45 0x4e 0x3d 0x7c
0x20 0x2f 0x75}
pc = 0x0000aaaaaaaa075c test.o`main + 8 at test.c:7:5
```
https://github.com/llvm/llvm-project/pull/188049
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
