https://github.com/JDevlieghere commented:
Please add a test as David suggested. As of right now, this PR is leaning towards being extractive (i.e. it's taking much more reviewing time than the value the change is adding) so please be mindful of that when iterating. Some things you can do to help with that are familiarizing yourself with the [LLVM Coding Standards](https://llvm.org/docs/CodingStandards.html) and looking at other PRs to see what reviewers look for (e.g. all PRs should come with a test). https://github.com/llvm/llvm-project/pull/188049 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
