================
@@ -147,6 +149,39 @@ class CommandObjectRegisterRead : public 
CommandObjectParsed {
   }
 
 protected:
+  uint32_t ComputeMatchingAlignment(RegisterContext *reg_ctx,
----------------
JDevlieghere wrote:

I'd make this a static function rather than a member. Right now it's somewhat 
unclear what should be passed as an argument and what's implicitly used from 
the class' members. 

I would also suggest calling this `ComputeLongestRegisterName` to better 
describe what this does rather than what it's used for.

https://github.com/llvm/llvm-project/pull/188049
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to