DavidSpickett wrote:

I see that tests are passing again which is good but means no test is hitting 
the scenario this code is trying to handle.

So you could simulate a remote with the required register names, like in 
`lldb/test/API/functionalities/gdb_remote_client/TestXMLRegisterFlags.py` and 
tests that use `MockGDBServerResponder`. LLDB might get confused if it's a name 
the client doesn't expect to ever see but in theory it should work as long as 
you're providing the required registers as well.

Though, if you apply this change to `register read x y z` too, then you can 
just pick N registers with varying name lengths and test it that way. I suggest 
x86 because that's what CI is, but I can find you a set for AArch64 as well if 
you like.

https://github.com/llvm/llvm-project/pull/188049
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to