I just joined llvm-dev today. Next time I'll have the commit thread. =)
On Thu, Feb 12, 2015 at 6:33 PM, Chandler Carruth <chandl...@google.com> wrote: > No one has even replied to the commit thread? that's where this kind of > discussion should took place. > > On Thu, Feb 12, 2015 at 6:27 PM, Zachary Turner <ztur...@google.com> > wrote: > >> Yea theres 886, 888, 889, and 890. I think all would have to be reverted. >> Is anyone on #llvm IRC that can help? >> >> On Thu, Feb 12, 2015 at 6:25 PM Vince Harron <vhar...@google.com> wrote: >> >>> IIRC I used >>> >>> llvm$ svn diff --revision 228885:228886 > ~/break.diff >>> >>> llvm$ patch -p0 -R < ~/break.diff >>> >>> Some hunks failed. Could've messed something up. >>> On Feb 12, 2015 6:20 PM, "Zachary Turner" <ztur...@google.com> wrote: >>> >>>> Hmm I checked the logs, that file hasn't been touched since that >>>> revision. What's unclean about the revert? Compile failure, or other test >>>> failure? >>>> On Thu, Feb 12, 2015 at 6:13 PM Vince Harron <vhar...@google.com> >>>> wrote: >>>> >>>>> It doesn't revert cleanly >>>>> On Feb 12, 2015 6:11 PM, "Zachary Turner" <ztur...@google.com> wrote: >>>>> >>>>>> We should revert this if it's definitely the culprit. Otherwise it's >>>>>> impossible for to detect another patch later which also causes a >>>>>> regression. It's easy to fix and resubmit later >>>>>> On Thu, Feb 12, 2015 at 6:03 PM Vince Harron <vhar...@google.com> >>>>>> wrote: >>>>>> >>>>>>> Hi Rafael, >>>>>>> >>>>>>> >>>>>>> http://lab.llvm.org:8011/builders/lldb-x86_64-debian-clang/builds/3326 >>>>>>> >>>>>>> Shows about 20 new test failures. I've narrowed it down to r228886 >>>>>>> >>>>>>> http://llvm.org/viewvc/llvm-project?revision=228886&view=revision >>>>>>> >>>>>>> Can you take a look and/or give me some idea what to look for? >>>>>>> >>>>>>> Thanks, >>>>>>> >>>>>>> Vince >>>>>>> >>>>>>> -- >>>>>>> >>>>>>> Vince Harron | Technical Lead Manager | vhar...@google.com | >>>>>>> 858-442-0868 >>>>>>> _______________________________________________ >>>>>>> lldb-dev mailing list >>>>>>> lldb-dev@cs.uiuc.edu >>>>>>> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev >>>>>>> >>>>>> >> _______________________________________________ >> lldb-dev mailing list >> lldb-dev@cs.uiuc.edu >> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev >> >> > -- Vince Harron | Technical Lead Manager | vhar...@google.com | 858-442-0868
_______________________________________________ lldb-dev mailing list lldb-dev@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
