Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page:
platform/linux-generic/pktio/socket_mmap.c
line 187
@@ -361,11 +365,13 @@ static void mmap_fill_ring(struct ring *ring, odp_pool_t
pool_hdl, int fanout)
pool->tailroom + TPACKET_HDRLEN +
TPACKET_ALIGNMENT + + (pz - 1)) & (-pz);
- /* Calculate how many pages do we need to hold all pool packets
Comment:
If we're cleaning up, might as well delete that extraneous `+` in the above
line: `TPACKET_ALIGNMENT + + (pz - 1)) & (-pz);` I'm surprised the compiler
doesn't flag that since it's normally so picky about issuing warnings.
> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
> Not sure I understand what `out_octets_tbl` is accumulating here. If I'm
> sending three 100 byte packets this will set `out_octets_tbl[0]` to 100,
> `out_octets_tbl[1]` to 200, and `out_octets_tbl[2]` to 300.
>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>> Since you're doing miscellaneous cleanups anyway, perhaps changing `len` to
>> `num` here should be considered? `len` is confusing since it doesn't
>> represent packet length.
>>> Matias Elo(matiaselo) wrote:
>>> The odp_pktin_maxlen() API states:
>>> > Maximum frame length in bytes that the packet IO interface can receive.
>>>
>>> I interpret this so that the application shouln't see packets which exceed
>>> pktin max length.
>>>
>>>> muvarov wrote
>>>> same here.
>>>>> muvarov wrote
>>>>> maybe to just set error bit and deliver this packet to application?
https://github.com/Linaro/odp/pull/397#discussion_r162222139
updated_at 2018-01-18 01:19:27
