Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page:

platform/linux-generic/pktio/loop.c
@@ -177,13 +177,15 @@ static int loopback_send(pktio_entry_t *pktio_entry, int 
index ODP_UNUSED,
        int i;
        int ret;
        uint32_t bytes = 0;
+       uint32_t out_octets_tbl[len];


Comment:
Since you're doing miscellaneous cleanups anyway, perhaps changing `len` to 
`num` here should be considered? `len` is confusing since it doesn't represent 
packet length.

> Matias Elo(matiaselo) wrote:
> The odp_pktin_maxlen() API states:
> > Maximum frame length in bytes that the packet IO interface can receive.
> 
> I interpret this so that the application shouln't see packets which exceed 
> pktin max length.
> 


>> muvarov wrote
>> same here.


>>> muvarov wrote
>>> maybe to just set error bit and deliver this packet to application?


https://github.com/Linaro/odp/pull/397#discussion_r162220004
updated_at 2018-01-18 01:19:27

Reply via email to