Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page:
platform/linux-generic/pktio/loop.c
@@ -177,13 +177,15 @@ static int loopback_send(pktio_entry_t *pktio_entry, int
index ODP_UNUSED,
int i;
int ret;
uint32_t bytes = 0;
+ uint32_t out_octets_tbl[len];
if (odp_unlikely(len > QUEUE_MULTI_MAX))
len = QUEUE_MULTI_MAX;
for (i = 0; i < len; ++i) {
hdr_tbl[i] = packet_to_buf_hdr(pkt_tbl[i]);
bytes += odp_packet_len(pkt_tbl[i]);
+ out_octets_tbl[i] = bytes;
Comment:
Not sure I understand what `out_octets_tbl` is accumulating here. If I'm
sending three 100 byte packets this will set `out_octets_tbl[0]` to 100,
`out_octets_tbl[1]` to 200, and `out_octets_tbl[2]` to 300.
> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
> Since you're doing miscellaneous cleanups anyway, perhaps changing `len` to
> `num` here should be considered? `len` is confusing since it doesn't
> represent packet length.
>> Matias Elo(matiaselo) wrote:
>> The odp_pktin_maxlen() API states:
>> > Maximum frame length in bytes that the packet IO interface can receive.
>>
>> I interpret this so that the application shouln't see packets which exceed
>> pktin max length.
>>
>>> muvarov wrote
>>> same here.
>>>> muvarov wrote
>>>> maybe to just set error bit and deliver this packet to application?
https://github.com/Linaro/odp/pull/397#discussion_r162220408
updated_at 2018-01-18 01:19:27
