Doh! - I shall rewrite history like it never happened ;) They are not required, but I think it's the best place for them. Where else do you propose?
On 8/04/2010, at 8:53 PM, Christian Grobmeier wrote: > Well, I somehow like this. > I am not sure about Apache Log4j-Contribtutions (note the spelling > error) and Performance Code - are these two really necessary? > > Christian > > On Thu, Apr 8, 2010 at 9:09 AM, Antony Stubbs <antony.stu...@gmail.com> wrote: >> More Mavenity goodness: >> http://github.com/astubbs/log4j/tree/modulriseify >> We now have >> [INFO] >> ------------------------------------------------------------------------ >> [INFO] Reactor Summary: >> [INFO] >> ------------------------------------------------------------------------ >> [INFO] Apache Log4j-Parent POM ............................... SUCCESS >> [5.369s] >> [INFO] Apache Log4j-Core ..................................... SUCCESS >> [21.342s] >> [INFO] Apache Log4j-Modules POM .............................. SUCCESS >> [0.029s] >> [INFO] Apache Log4j-Chainsaw V1 .............................. SUCCESS >> [4.084s] >> [INFO] Apache Log4j-Net ...................................... SUCCESS >> [4.933s] >> [INFO] Apache Log4j-Contribtutions ........................... SUCCESS >> [7.657s] >> [INFO] Apache Log4j-LF5 ...................................... SUCCESS >> [9.700s] >> [INFO] Apache Log4j-Performance Code ......................... SUCCESS >> [5.164s] >> [INFO] >> ------------------------------------------------------------------------ >> [INFO] >> ------------------------------------------------------------------------ >> [INFO] BUILD SUCCESSFUL >> [INFO] >> ------------------------------------------------------------------------ >> [INFO] Total time: 59 seconds >> [INFO] Finished at: Thu Apr 08 18:57:28 NZST 2010 >> [INFO] Final Memory: 45M/252M >> [INFO] >> ------------------------------------------------------------------------ >> With the test results (fixed the majority of them, only a couple left) for >> log4j-core: >> Results : >> >> Failed tests: >> propertiesTest(org.apache.log4j.defaultInit.TestCase3) >> combinedTest(org.apache.log4j.defaultInit.TestCase4) >> xmlTest(org.apache.log4j.defaultInit.TestCase2) >> >> Tests in error: >> test2(org.apache.log4j.varia.ErrorHandlerTestCase) >> toLevelTest2(org.apache.log4j.helpers.OptionConverterTestCase) >> toLevelTest3(org.apache.log4j.helpers.OptionConverterTestCase) >> toLevelTest4(org.apache.log4j.helpers.OptionConverterTestCase) >> toLevelTest5(org.apache.log4j.helpers.OptionConverterTestCase) >> >> Tests run: 649, Failures: 3, Errors: 2, Skipped: 0 >> With the test results (fixed the majority of them, only a couple left) for >> log4j-net: >> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.195 sec >> Results : >> Tests in error: >> Tests run: 32, Failures: 0, Errors: 3, Skipped: 0 >> NT is disabled though - that ones a little more tricky to migrate. >> Give it a go and let me know your thoughts: >> git clone git://github.com/astubbs/log4j.git >> git checkout origin/modulriseify >> Cheers! >> >> <antony.stu...@gmail.com>wrote: >> >> Hi guys, following on from my comment, I've uploaded a proposed >> >> modularisation here: >> >> http://github.com/astubbs/log4j/commit/7c5b4689d5cc509d207e3270fc6f012ea8064c6d >> >> http://github.com/astubbs/log4j/commit/ce3ce992d509e8c341914437bbc11442711fc5bf >> >> As well as the module split, I would also do a more complete maven >> >> migration >> >> (except for possibly the NT build stuff). >> >> My immediate drive for this (apart from the other obvious benefits) is >> >> the >> >> file size of the log4j jar (~800k). Removing LF5 alone removes 490k >> >> (uncompressed). >> >> I know this drives up the complexity, but I think it is worth if to get >> >> the >> >> at least the GUI stuff out. >> >> Cheers. >> >> >> Antony Stubbs wrote: >> >> Hi guys, what's the established opinion from log4j about breaking >> >> log4j up into modules ie net, nt appender, chainsaw etc? >> >> Regards, >> >> Antony Stubbs >> >> Technical Architect - Prototyping >> >> Telecom Retail >> >> --------------------------------------------------------------------- >> >> To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org >> >> For additional commands, e-mail: log4j-dev-h...@logging.apache.org >> >> >> >> ----- >> >> ___________________________ >> >> http://stubbisms.wordpress.com >> >> >> >> ----- >> >> ___________________________ >> >> http://stubbisms.wordpress.com http://stubbisms.wordpress.com >> >> -- >> >> View this message in context: >> >> http://old.nabble.com/Modular-Build-tp28170343p28172026.html >> >> Sent from the Log4j - Dev mailing list archive at Nabble.com. >> >> >> --------------------------------------------------------------------- >> >> To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org >> >> For additional commands, e-mail: log4j-dev-h...@logging.apache.org >> >> >> >> >> >> >> ----- >> ___________________________ >> >> http://stubbisms.wordpress.com http://stubbisms.wordpress.com >> -- >> View this message in context: >> http://old.nabble.com/Modular-Build-tp28170343p28172150.html >> Sent from the Log4j - Dev mailing list archive at Nabble.com. >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org >> For additional commands, e-mail: log4j-dev-h...@logging.apache.org >> >> >> --------------------------------------------------------------------- To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
