Thank you for reminding me. I did a quick check, then I saw its actually worse. I found a couple of classes which we need to look into before can make this release. Not even that they are duplicated, I found one class which has a different implementation. :-(
That said, I would like to require companions 1.2 at least 1.2.16 if not 1.2.17. Jess, would this work for you? These are the classes I found duplicated: UnrecognizedElementHandler -> same XSLTLayout -> different implementation EnhancedPatternLayout -> looks similar at least LogSF -> looks similar at least LogXF -> looks similar at least LogMF -> looks similar at least BridgePatternConverter.java BridgePatternParser.java CachedDateFormat.java ClassNamePatternConverter.java DatePatternConverter.java FileDatePatternConverter.java FileLocationPatternConverter.java FormattingInfo.java FullLocationPatternConverter.java IntegerPatternConverter.java LevelPatternConverter.java LineLocationPatternConverter.java LineSeparatorPatternConverter.java LiteralPatternConverter.java LogEvent.java LoggerPatternConverter.java LoggingEventPatternConverter.java MessagePatternConverter.java MethodLocationPatternConverter.java NDCPatternConverter.java NameAbbreviator.java NamePatternConverter.java PatternConverter.java PatternParser.java PropertiesPatternConverter.java RelativeTimePatternConverter.java SequenceNumberPatternConverter.java ThreadPatternConverter.java ThrowableInformationPatternConverter.java MDCKeySetExtractor.java UtilLoggingLevel.java On Sat, May 4, 2013 at 1:47 PM, Jess Holle <je...@ptc.com> wrote: > apache-log4j-extras-1.2.jar contains redundant copies of many of the log4j > classes. > > This was an issue in log4j-extras 1.1 as well, so this is not new. See the > "Serious log4j-extras issue" thread from Dec. 7th, 2012. > > As per that thread, I've had some rather nasty experiences with this in the > past -- where I've needed to patch classes in log4j (to avoid concurrency > and deadlock issues) and done so, only to find after the code was in > production that a new version of log4j-extras also included the same > classes, ended up first in classloader order and thus overrode all my > patches. I eventually ended up hacking a short Ant script to produce a new > jar excluding any entry outside META-INF that exists in the latest > log4j.jar. > > log4j-extras 1.2 really should resolve this issue. I suspect that will mean > that log4j-extras 1.2 will need to articulate a specific minimum log4j 1.2.x > version that provides all the classes (and methods) it needs, as I suspect > that log4j-extras includes log4j classes to try to work with older log4j > versions. Including redundant classes is not really a solution, though, as > it causes issues like that noted above. > > -- > Jess Holle > > > On 5/4/2013 5:14 AM, Christian Grobmeier wrote: > > Dear all, > > this is a vote for a new Apache Companions package. > > Please note: it's the first release since 2010. It's far from routine. > > Changes: > - all companions have been merged into the extras companion > - pom does inherit from parent pom > - testoutput now goes to /target > - ant build has been removed > - makes now use of Maven 3 > > The website can be found here: > > * http://people.apache.org/~grobmeier/log4j-companions/ > > Note: I might need to update the path for the download. > > Artifacts for Maven: > > * https://repository.apache.org/content/repositories/orgapachelogging-175/ > > They can be downloaded with: > > wget -e robots=off --cut-dirs=3 -r -p -np --no-check-certificate > https://repository.apache.org/content/repositories/orgapachelogging-175/ > > Artifacts for the website and for the ASF dist svn: > > * http://people.apache.org/~grobmeier/log4j-companions-artefacts/ > > SVN tag: > > * > http://svn.apache.org/repos/asf/logging/log4j/companions/extras/tags/apache-log4j-extras-1.2/ > > Please cast your vote: > > [ ] +1 > [ ] -1, because... > > Vote will be open for the usual 72 hours at least. > > Thanks, > Christian > > --------------------------------------------------------------------- > To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org > For additional commands, e-mail: log4j-dev-h...@logging.apache.org > > > -- http://www.grobmeier.de https://www.timeandbill.de --------------------------------------------------------------------- To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
