I have just compare all files I found duplicated. These two have additional functionality:
FormattingInfo.java PatternParser.java Its just minor things, like adding of padding. I copied the features over to log4j. If I remove these classes right now, extras would depend on a snapshot which is not good. My idea was to rename these two classes and mark them deprecated. Still breaking is you urgently need these features but they are most likely not used often and I would take this risk. Comments? The other files could be deleted. In some cases the docs were different, I have them in my log4j-trunk and will commit it too. UnrecognizedElementHandler EnhancedPatternLayout LogSF LogXF LogMF BridgePatternConverter.java BridgePatternParser.java CachedDateFormat.java ClassNamePatternConverter.java DatePatternConverter.java --> lost unnecessary cast to string FileDatePatternConverter.java FileLocationPatternConverter.java FullLocationPatternConverter.java IntegerPatternConverter.java LevelPatternConverter.java LineLocationPatternConverter.java LineSeparatorPatternConverter.java LiteralPatternConverter.java LogEvent.java LoggerPatternConverter.java LoggingEventPatternConverter.java MessagePatternConverter.java MethodLocationPatternConverter.java NDCPatternConverter.java NameAbbreviator.java NamePatternConverter.java PatternConverter.java PropertiesPatternConverter.java RelativeTimePatternConverter.java SequenceNumberPatternConverter.java ThreadPatternConverter.java ThrowableInformationPatternConverter.java MDCKeySetExtractor.java UtilLoggingLevel.java Cheers Christian On Sat, May 4, 2013 at 2:32 PM, Jess Holle <je...@ptc.com> wrote: > On 5/4/2013 7:02 AM, Christian Grobmeier wrote: >> >> Thank you for reminding me. I did a quick check, then I saw its >> actually worse. I found a couple of classes which we need to look into >> before can make this release. Not even that they are duplicated, I >> found one class which has a different implementation. :-( > > Wow! I'd have assumed that the classes were just copied over from some > log4j 1.2.x version or another. Perhaps they were and then someone felt > like improving upon them and didn't understand their ancestry. > >> That said, I would like to require companions 1.2 at least 1.2.16 if >> not 1.2.17. Jess, would this work for you? > > I'm absolutely fine with requiring 1.2.17. > > -- > Jess Holle > -- http://www.grobmeier.de https://www.timeandbill.de --------------------------------------------------------------------- To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
