On Mon, Jun 2, 2014 at 9:57 AM, Remko Popma <remko.po...@gmail.com> wrote:
> I would not be in favor of forcing users to have an extra dependency. They > should be able to use log4j with just the core and api jars. > > Making life a little easier for us is not a compelling reason to add a > dependency on an xml library IMO. > The code we have to maintain is not trivial IMO, so it is making our lives a lot easier. That is my impression from working with Jackson for the XML and JSON Event IO. In the big pictures, my apps, all server side, end up depending on lots of stuff and more stuff brought in transitively. Even for "simple" command line tools, I always bring in more than log4j. But I do understand the need for a lightweight profile... which can only be done using an XML config. One could argue that XML is not lightweight and that a real lightweight config should be done with the sys props or a prop file... ;-) Gary > > Sent from my iPhone > > On 2014/06/02, at 22:48, Matt Sicker <boa...@gmail.com> wrote: > > Jackson is how we handle YAML and JSON configs anyways. It might be worth > looking into for 2.1. > > > On 2 June 2014 08:19, Gary Gregory <garydgreg...@gmail.com> wrote: > >> I'm not trying to handle all cases under the sun. But... we've chosen NOT >> to use an XML Schema based XML IO framework (like JAXB or Jackson), instead >> we've invented our own. I know we do JSON as well, but so does Jackson and >> it likely also has a plugin for YAML. So now, every time I'm looking for >> some minor improvement, it means tweaking our custom framework or adding >> boilerplate code to plugins. It's a pain, but that's where we are today. At >> least now, with the new type converters, I get the type conversion from to >> int for free :-) >> >> In this case, I meant, you can only use attribute A or B. >> >> It is probably worth stepping back and looking at the big picture and >> whether we want to invest in improving the current config IO framework or >> at least consider if Jackson would be a better fit. Likely not for 2.0 ;-) >> >> Gary >> >> >> On Mon, Jun 2, 2014 at 4:03 AM, Ralph Goers <rgo...@apache.org> wrote: >> >>> Are you looking for annotations to handle every kind of thing you might >>> like to do instead of just putting a couple lines of code in the factory >>> method? I would have handled this by saying foo and bar both need to be >>> Integer and then adding a line do code that insures exactly one, or at most >>> one, is present ( depending on what you want ). >>> >>> I really have no idea what it means for an attribute or element to be in >>> a "choice". Does it mean at most one is specified or exactly one? What if I >>> want exactly one in some cases and at most one in others? >>> >>> Ralph >>> >>> On Jun 1, 2014, at 11:53 PM, Gary Gregory <garydgreg...@gmail.com> >>> wrote: >>> >>> How do I tell my plugin that it can have attribute1 or 2, but not both? >>> IOW I want the config framework to do the validation for me. >>> >>> How about: >>> >>> >>> @PluginAttribute(choice="group1") int foo, >>> >>> >>> >>> @PluginAttribute(choice="group1") int bar >>> >>> Same thing for elements. >>> >>> Thoughts? >>> >>> Gary >>> >>> -- >>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >>> Java Persistence with Hibernate, Second Edition >>> <http://www.manning.com/bauer3/> >>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >>> Spring Batch in Action <http://www.manning.com/templier/> >>> Blog: http://garygregory.wordpress.com >>> Home: http://garygregory.com/ >>> Tweet! http://twitter.com/GaryGregory >>> >>> >> >> >> -- >> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >> Java Persistence with Hibernate, Second Edition >> <http://www.manning.com/bauer3/> >> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >> Spring Batch in Action <http://www.manning.com/templier/> >> Blog: http://garygregory.wordpress.com >> Home: http://garygregory.com/ >> Tweet! http://twitter.com/GaryGregory >> > > > > -- > Matt Sicker <boa...@gmail.com> > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
