Hello, i think we have never discussed it at log4php before (just 2 people max :-)) but I think we should follow "Commit then review". If it is a huge, nasty piece of code we can discuss it before on the mailinglist.
What do you think guys? Cheers Christian On Sat, Feb 11, 2012 at 8:45 PM, Florian Semm (Updated) (JIRA) <[email protected]> wrote: > > [ > https://issues.apache.org/jira/browse/LOG4PHP-141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > ] > > Florian Semm updated LOG4PHP-141: > --------------------------------- > > Attachment: LOG4PHP-141.patch > > only a patch, because i want a review ;) > > it also includes the fix from LOG4PHP-127 > >> Allow setting of a default Renderer for all Classes >> --------------------------------------------------- >> >> Key: LOG4PHP-141 >> URL: https://issues.apache.org/jira/browse/LOG4PHP-141 >> Project: Log4php >> Issue Type: Improvement >> Components: Code >> Affects Versions: 2.0 >> Reporter: igor nadj >> Attachments: LOG4PHP-141.patch >> >> >> In log4j you can set a default renderer for all Classes by configuring a >> Renderer for the Object class, as all Classes extend Object. But PHP does >> not have a base class like Java, and it would be nice to have a way to >> replicate this behaviour. > > -- > This message is automatically generated by JIRA. > If you think it was sent incorrectly, please contact your JIRA > administrators: > https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa > For more information on JIRA, see: http://www.atlassian.com/software/jira > > -- http://www.grobmeier.de https://www.timeandbill.de
