[ 
https://issues.apache.org/jira/browse/LOG4PHP-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209252#comment-13209252
 ] 

Ivan Habunek commented on LOG4PHP-141:
--------------------------------------

I haven't had a proper look at the code yet because of the work on the release 
, but I have a few thoughts.

I agree that it would be better to add a new attribute, rather than specifying 
"Object" for rendered class. Maybe just "defaultRenderer"? Do we plan to have 
any other renderers apart from object rendererds?

Looking at the naming, I would prefer that the renderer interface be called 
LoggerRenderer instead of LoggerRendererInterface. To keep the same naming 
scheme as LoggerConfigurator interface.

This is just some initial ideas. I will have a better look at the code for the 
weekend. 

Cheers!

                
> Allow setting of a default Renderer for all Classes
> ---------------------------------------------------
>
>                 Key: LOG4PHP-141
>                 URL: https://issues.apache.org/jira/browse/LOG4PHP-141
>             Project: Log4php
>          Issue Type: Improvement
>          Components: Code
>    Affects Versions: 2.0.0
>            Reporter: igor nadj
>         Attachments: LOG4PHP-141.patch
>
>
> In log4j you can set a default renderer for all Classes by configuring a 
> Renderer for the Object class, as all Classes extend Object. But PHP does not 
> have a base class like Java, and it would be nice to have a way to replicate 
> this behaviour.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to