Hi Florian,

Sorry, not having much free time recently.

I'm looking at your patch now and it seems a little broken. For start,
the tests fail in many interesting ways. :)

I notice that you deleted LoggerRendererObject, but it's still
referenced in code. Also you are missing LoggerRendererInterface.
Maybe this was accidental. Can you have a look?

I agree we need two attributes.

Regards,
Ivan



On 21 February 2012 07:57, Florian Semm <[email protected]> wrote:
> Am 16.02.2012 12:01, schrieb Florian Semm (Commented) (JIRA):
>
>     [
> https://issues.apache.org/jira/browse/LOG4PHP-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209270#comment-13209270
> ]
>
> Florian Semm commented on LOG4PHP-141:
> --------------------------------------
>
> at the moment there are two default-renderer: one for objects, another for
> string/number/whatever. if we keep this default-renderer we need two new
> attributes.
>
> to change the naming is no problem.
>
>
> Allow setting of a default Renderer for all Classes
> ---------------------------------------------------
>
>                 Key: LOG4PHP-141
>                 URL: https://issues.apache.org/jira/browse/LOG4PHP-141
>             Project: Log4php
>          Issue Type: Improvement
>          Components: Code
>    Affects Versions: 2.0.0
>            Reporter: igor nadj
>         Attachments: LOG4PHP-141.patch
>
>
> In log4j you can set a default renderer for all Classes by configuring a
> Renderer for the Object class, as all Classes extend Object. But PHP does
> not have a base class like Java, and it would be nice to have a way to
> replicate this behaviour.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators:
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
> Hi,
>
> any new opinions about that?
>
>
> regards,
>
> Florian

Reply via email to