On 12 February 2012 10:16, Christian Grobmeier <[email protected]> wrote:
> Hello, > > i think we have never discussed it at log4php before (just 2 people max > :-)) > but I think we should follow "Commit then review". If it is a huge, > nasty piece of code we can discuss it before on the mailinglist. > > What do you think guys? > > I don't mind doing a review for the first few commits. I know how it is when you start and aren't 100% you're not breaking anything. I will do it when I get a little free time. I was wondering myself how to solve this issue, and it will be interesting to see how Florian soved it. If it's a "huge nasty piece", we can make a branch for it. However, I am thinking about making that patch release we have been talking about. Because of this, I would appreciate no new features being committed until we ship this thing. Regards, Ivan
